Chris Hupman <chris...@...>
toggle quoted message Show quoted text
I looked at all the PRs targeting 0.2 and currently I'm only really optimistic about 1575 making it in for the release. Right now the only thing I would consider delaying for is 1479, the service-wrapper PR, but I'm hoping to close that out this week. Here are my notes on the 4 PRs.
I did a full pass on this, but I want a second binding approval before this gets merged. I did some digging, but I still don't have a clear picture in my head of what acquireLocks() should look like.
I approved, but it will require a second approval to merge. At least the test will be easy to merge upstream.
This PR should probably be targeting master, otherwise you'll need to address the test failures on es1 and es2. I didn't do a review since it wasn't passing CI.
I did a pass and there were two items to resolve. The main one being adding a test. Since it requires a mock I would rather it goes into 0.3 or 0.4 so that we won't have to convert the test from easyMock to Mockito and junit 4 to junit 5.
Just so I understand better is there a push to get into 0.2.3 so you won't have to update to 0.3.x to get access to the features? Or did you just target 0.2 so the changes would make it into all the releases?
On Tuesday, May 14, 2019 at 5:10:10 AM UTC-7, Florian Hockmann wrote: