Re: [DISCUSS] PR targeting for enhancement, feature, bugfix and breaking changes


Jason Plurad <plu...@...>
 

Ah, fair enough, enhancement makes sense when explained more fully by example.


On Monday, July 1, 2019 at 9:19:00 AM UTC-4, Oleksandr Porunov wrote:
If an issue suggests a performance improvement, can we label it as a "bugfix"?

On Monday, July 1, 2019 at 3:59:52 PM UTC+3, Jason Plurad wrote:
I think "enhancement" can be easily confused with "feature". I'd suggest to stick with "bugfix" for items that would go into any branch.

On Monday, July 1, 2019 at 7:34:59 AM UTC-4, Oleksandr Porunov wrote:
Hello,

Currently both new features and enhancements are labeled as "enhancement".
I am proposing to introduce new labels: 
- "feature" - a new functionality
- "breaking changes" - breaking changes

After that I am proposing to use the next PR targeting scheme:
- "breaking changes" and "feature" can go only to master branch
- "enhancement" and "bugfix" can go to any branch

I don't think that we need a special voting for this that is why I will wait for 1 week for other comments from contributors. If everyone is OK with it then we can stick to a new PR targeting scheme

Best regards,
Oleksandr

Join janusgraph-dev@lists.lfaidata.foundation to automatically receive all group messages.