Re: [DISCUSS] PR targeting for enhancement, feature, bugfix and breaking changes

Oleksandr Porunov <alexand...@...>

I also think that we need some policy but it is hard to say right now where should this "enhancement" go. Some improvements cannot go to older branches and some can. For example, it could be a storage version related enhancement in such case the enhancement must go to the branches where it would work (i.e. to the oldest branch where this storage version is enabled). Other improvements could be based on some work which is done in some branch. For example, we could refactor code in the latest branch and not in the old branches and the improvement is easily applied to the refactored code but is hard to be applied to old code in old branches. In such case I would say that the contributor should decide where it should be applied. I.e. in some cases the improvement can be applied to old branches but with a lot of additional work which the contributor don't won't to do. So it is hard for me to suggest a single policy which will work for everyone. I would say, it depends on the concrete case. 

P.S. I am using "enhancement" and "improvement" as synonims. By "enhancement" I mean "improvement" and not "new funcionality".

On Tuesday, July 2, 2019 at 4:40:42 PM UTC+3, Florian Hockmann wrote:
I'm fine with adding labels for features and breaking changes, but where I'm not sure about is this part:

"enhancement" and "bugfix" can go to any branch

Who decides here which branch to target? The contributor? Any reviewer?

I think we should have a policy that specifies which kind of contribution should target which branch and it should ideally be easy to understand.

Am Dienstag, 2. Juli 2019 15:38:29 UTC+2 schrieb Jason Plurad:
Ah, fair enough, enhancement makes sense when explained more fully by example.

On Monday, July 1, 2019 at 9:19:00 AM UTC-4, Oleksandr Porunov wrote:
If an issue suggests a performance improvement, can we label it as a "bugfix"?

On Monday, July 1, 2019 at 3:59:52 PM UTC+3, Jason Plurad wrote:
I think "enhancement" can be easily confused with "feature". I'd suggest to stick with "bugfix" for items that would go into any branch.

On Monday, July 1, 2019 at 7:34:59 AM UTC-4, Oleksandr Porunov wrote:

Currently both new features and enhancements are labeled as "enhancement".
I am proposing to introduce new labels: 
- "feature" - a new functionality
- "breaking changes" - breaking changes

After that I am proposing to use the next PR targeting scheme:
- "breaking changes" and "feature" can go only to master branch
- "enhancement" and "bugfix" can go to any branch

I don't think that we need a special voting for this that is why I will wait for 1 week for other comments from contributors. If everyone is OK with it then we can stick to a new PR targeting scheme

Best regards,

Join { to automatically receive all group messages.