Florian Hockmann <f...@...>
toggle quoted message
Show quoted text
So, we keep this VOTE thread for this release?
In that case: I tested the new distributions by starting JanusGraph Server with the in-memory backend on both as described in the docs and then connected successfully with the Gremlin Console via remote to that. For the full distribution, I also tested the same with bin/janusgraph.sh. Everything worked as expected.
I therefore change my VOTE to +1.
Am Samstag, 4. April 2020 19:23:58 UTC+2 schrieb Oleksandr Porunov:
gremlin-server has been fixed. Release jars, Sonatype artifacts and git tag have been updated
On Wednesday, April 1, 2020 at 12:30:31 PM UTC-7, Oleksandr Porunov wrote:
I also checked that gremlin server has the same problem with version 0.4.0. Also, it doesn't even start by default in 0.3.1 version. So, this bug is here for a long time.
I also agree on your suggestions about naming of releases. Maybe it is better to keep `janusgraph-0.5.1.zip` as a full janusgraph version and `janusgraph-0.5.1-truncated.zip` as a truncated version.
On Wednesday, April 1, 2020 at 9:54:50 AM UTC-7, Florian Hockmann wrote:
It fails for both versions. The big problem I see with this is that our docs say about this:
By default, this will instruct JanusGraph to use it's own inmemory backend instead of a dedicated database server.
so it should really not expect some externally running Cassandra or Elasticsearch. This problem was probably already present at least in 0.5.0, but I think that it gets worse with this release because we now have the truncated zip archive as the default distribution (it's named just janusgraph-[version].zip after all and not [janusgraph-[version]-truncated.zip) and that doesn't contain a method any more to easily start JanusGraph Server like it's described in the docs. For the full distribution, users could at least switch back to janusgraph.sh which should still work.
That is why I think that we should really fix that before releasing a truncated distribution or if we really want to release now, then we should treat the full archive as the default distribution and the truncated one as an addition for users who want to save some disk space and who know that they have to manage backends on their own.
Am Mittwoch, 1. April 2020 18:21:14 UTC+2 schrieb Oleksandr Porunov:
Florian, thank you for catching it. I didn't check yet but does "./bin/gremlin-server.sh start" fails on both truncated and full JanusGraph versions? I.e. I assume you should run CQL and ES externally when you are using a truncated JanusGraph version. We already have information in our documentation that "This requires to download
janusgraph-full-0.5.1.zip instead of the default
janusgraph-0.5.1.zip". I.e. I assume that it is OK that default ./bin/gremlin-server.sh start fails in truncated version because it is described in the documentation.
Also, if it fails in full version also, does it work in any JanusGraph version (i.e. 0.4.0 or 0.3.0)? In case it doesn't work with older JanusGraph version, then we don't introduce any new bugs and thus the bugfix can be postponed for the future releases (unless the bug can be fixed quickly or the bug is critical). That said, I didn't yet check those bugs you have described, I will try to check them later.
On Wednesday, April 1, 2020 at 7:26:46 AM UTC-7, Florian Hockmann wrote:
I just tried both zip archives, following our docs on local installation
that simply starts JanusGraph Server with ./bin/gremlin-server.sh start
. This fails silently which can be noticed when one tries to connect to that from the console with :remote connect
as that results in this error message: gremlin-groovy is not an available GremlinScriptEngine
This seems to be caused by the fact that gremlin-server.sh
uses the default gremlin-server.yaml
which uses CQL and ES
If we now point users at gremlin-server.sh to get started instead of janusgraph.sh as that isn't included in the truncated version, then we need to make sure that this actually works out of the box.
So, my VOTE is -1.
Am Samstag, 28. März 2020 23:27:49 UTC+1 schrieb Jan Jansen:
I have tested the truncated binary distribution, using the a pre-built docker image of janusgraph.
My vote is +1.
On Thursday, March 26, 2020 at 2:21:41 AM UTC+1, Oleksandr Porunov wrote: