BTW, the doc suggests that you start with signing the CLA before forking and raising pull request. In case of individual contribution this is easy and fast, but for corporate route (which I am guessing you have to go through) it can be a long and unexciting part of contribution process. 

Likewise, getting your changes to be reviewed can also take time, depending on how big and complex your change is, and how many people are familiar enough with that part of code.

So I suggest that you raise the PR as early in the process as possible, and the CLA bit can catch up (while it's still obviously required before your contribution can be finally accepted)

On Thu, 11 Jun 2020 at 11:17, Dmitry Kovalev <d...@...> wrote:

Hi Shiva,

Thanks for taking time to dive into the issue and deciding to contribute.

Please have a look at this page: https://github.com/JanusGraph/janusgraph/blob/master/CONTRIBUTING.md - it describes the steps to contribute, which are pretty standard.

Thanks,

Dmitry

On Thu, 11 Jun 2020 at 10:40, <shi...@...> wrote:

Hello Everyone,

I have found the root cause for this issue and also have the fix for the same.

Please guide me if I can contribute for this project as I'm new to this community.

Thanks

Shiva

On Monday, June 8, 2020 at 6:50:04 PM UTC+5:30, Shiva Krishnan wrote:

Hi,

I have noticed a corruption in index after reindexing vertex-centric indices with direction 'IN'.

Issue : A self-link is getting added to every vertex after reindexing.

To demonstrate this, I have taken a very small graph consists of two vertices (A & B) and one edge connecting the two.

Edge Label -> link

Edge has one property key (Integer) -> assocKind

//Creating the Vertex Centrix Index

gremlin > edgeLabel = mgmt.getEdgeLabel("link");

gremlin > assocKind= mgmt.getPropertyKey("assocKind")

gremlin > mgmt.buildEdgeIndex(edgeLabel, "myVertexCentricIndex", Direction.IN, assocKind);

Please note i have given the direction IN for the index.

//Creating the Edge from A to B: (a and b are vertices)

a.addEdge("link",b,"assocKind",1)

Output Before Reindexing :

gremlin> g.V().has('name' , 'A').inE().hasLabel('link').has('assocKind',1)

//no IN edges to vertex A  Correct

gremlin> g.V().has('name' , 'A').outE().hasLabel('link').has('assocKind',1)

==>e[4e1f-b6g-1bit-1pqw][14488-link->80024]   Correct

Now I ran the reindex command

// 'index' is the vertex centric index which is created above

gremlin> m.updateIndex(index, SchemaAction.REINDEX).get()

Output After Reindexing :

gremlin> g.V().has('_objId','A').inE().hasLabel('link').has('assocKind',1)

==>e[4e1f-b6g-1bit-b6g][14488-link->14488] Wrong

gremlin> g.V().has('_objId','A').bothE().hasLabel('link').has('assocKind',1)

==>e[4e1f-b6g-1bit-1pqw][14488-link->80024]

==>e[4e1f-b6g-1bit-b6g][14488-link->14488] Unexpected Link

This issue happens in janusgraph 0.5.2 also.

Thanks

Shiva

--
You received this message because you are subscribed to the Google Groups "JanusGraph developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to janusgr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/janusgraph-dev/ea55b56a-dc8b-456e-b8c9-071de9b9f35ao%40googlegroups.com.