1. Messages
  2. [DISCUSS] Move to GitHub Actions

Re: [DISCUSS] Move to GitHub Actions

Florian Hockmann <f...@...>
 

OK, looks like we have a consensus on moving to GitHub Actions. Then we can start with the migration now.

> I created an example for GitHub Actions by converting the foundation db travis ci to github actions.

> I also add two extra workflow to check a editorconfig and check for license header which can be copied over to all of our repos.

> What do you think of GitHub Actions?

Thanks, Jan, for working on this already so we have an example to see GitHub Actions working on one of our repos. I think it looks really promising! It's also nice to see how easy it is to add such additional checks.
I would though recommend that we don't do all at once in a single PR as that makes them harder to review and instead create follow-up PRs for the editorconfig and the license check. Adding these checks bloats the PR a bit as files unrelated to CI now need to be modified to get the checks green.

fa...@... schrieb am Samstag, 21. November 2020 um 18:04:59 UTC+1:

I created an example for GitHub Actions by converting the foundation db travis ci to github actions.

I also add two extra workflow to check a editorconfig and check for license header which can be copied over to all of our repos.

What do you think of GitHub Actions?

On Friday, November 20, 2020 at 8:33:52 AM UTC+1 Ja...@... wrote:

Currently, we have 6 repos with CI pipeline. So we have to convert all of the repos with a CI pipeline.

I already checkout how do you convert a dotnet project. I think will be helpful to do a step by step migration.
We should start with the small projects and than go to the main project.

Von: jan...@... <jan...@...> im Auftrag von Lakshay Rastogi <laks...@...>
Gesendet: Freitag, 20. November 2020 04:32:17
An: jan...@...
Betreff: Re: [DISCUSS] Move to GitHub Actions
 
What would be required in terms of development in order to move to GitHub actions? 

On Fri, Nov 20, 2020, 4:09 AM Oleksandr Porunov <alex...@...> wrote:
Hi,

If that's the case, as for me it's obvious way to go.
+1 for moving to GitHub Actions

Best regards,
Oleksandr

On Thursday, November 19, 2020 at 11:38:32 PM UTC+2 Ja...@... wrote:
Hi

I’m pretty sure about our limitations, which are just 20 concurrent runner at the same time for all public repos. The 2000 minutes are just for private repos (no build time limit for public repos).

Greetings, 
Jan 

On 19. Nov 2020, at 21:55, Oleksandr Porunov <alex...@...> wrote:


Hi,

Moving to GitHub actions seems to be a good idea but we need to understand our limitations. This link says that GitHub actions gives us 2000 minutes per month:

Best regards,
Oleksandr
On Wednesday, November 18, 2020 at 12:24:51 PM UTC+2 fa...@... wrote:
Hi

I did a small evaluation of GitHub Actions in February. GitHub Actions didn't allowed to run to open source project unlimited time at this time. This changed in April.

Old results can be found here.

Greetings,
Jan

On Wednesday, November 18, 2020 at 11:05:41 AM UTC+1 Florian Hockmann wrote:
Hi,

Travis CI has recently announced that they will only offer 1000 build minutes / month for OSS projects. Given that our builds currently take ~10h, we would only be able to execute around 2 builds per month of our main repository. While the linked
blog post also mentions the possibility to request more free build minutes, I'm not sure whether we want to rely on that and how realistic it is that they will provide us with enough build minutes. (Just to give an example: We would need around 50,000 build minutes per month to be able to execute 3 builds per day.)

To make matters worse, we're still on travis-ci.org which will be abandoned at the end of this year in favor of travis-ci.com. So, even if we want to stay with Travis, we would need to migrate our projects over from travis-ci.org to travis-ci.com.

Given these policy changes by Travis CI, I propose that we migrate to GitHub Actions which seems to be much more OSS friendly nowadays and which probably also allows us to better parallelize and therefore speed up our builds. It allows up to 20 concurrent jobs with a maximum runtime of 6h per job. This should also make it easier to execute the TinkerPop tests for more backends.

Any thoughts or concerns on this topic?


PS: For a bit more context about the changes in Travis CI for OSS projects, I recommend this blog post which made me aware of this in the first place.

--
You received this message because you are subscribed to the Google Groups "JanusGraph developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to janusg...@....
To view this discussion on the web visit https://groups.google.com/d/msgid/janusgraph-dev/7fd40424-814e-4afd-abe6-70834a5d5b94n%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "JanusGraph developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to janusg...@....
To view this discussion on the web visit https://groups.google.com/d/msgid/janusgraph-dev/3513c4ab-9197-438e-b08f-e375ff91ef0fn%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "JanusGraph developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to janusg...@....
Join janusgraph-dev@lists.lfaidata.foundation to automatically receive all group messages.