toggle quoted messageShow quoted text
Samant, It's been 5 days and no one has yelled too loud so I think it's reasonable to move forward with your PR on this if you're still up for it.
Ted, I don't think the reorganization here would cause any additional complexities with the eventual deprecation of Thrift. On the surface it seems to me it might make it simpler to carry out the deprecation/removal if the Thrift components are separated into a standalone module like here.
On Friday, June 23, 2017 at 10:45:50 PM UTC-5, sjudeng wrote:
Samant has said he should be able to continue working on this effort. The current proposal is to refactor into the following structure.
│ ├── astyanax
│ ├── cql
│ ├── core
│ ├── embedded
│ ├── test
│ ├── thrift
+1 for me. I think it's a step in the right direction and I'd hate to see the work already done on this go to waste.
Jason, is this something that needs a separate vote thread or can the work/PR just move forward?
Samant, What do you think about Ted's question above?
On Saturday, June 17, 2017 at 12:28:41 PM UTC-5, sjudeng wrote:
Are you still able to move forward with getting your work on this submitted? If so do you want to call a vote on the proposed refactoring or do you want me to? One way or another I think the refactoring is definitely needed. It came up in a recent PR where configuration needed to be duplicated in janusgraph-cassandra and janusgraph-cql because of the current state of things.