|
Re: [DISCUSS] Adding static code analysis into our review process
I mainly referred to the Python library with my earlier comment regarding the size of the PR. There, it would probably have been possible to first create a smaller PR with just a minimal level of
I mainly referred to the Python library with my earlier comment regarding the size of the PR. There, it would probably have been possible to first create a smaller PR with just a minimal level of
|
By
Florian Hockmann <f...@...>
·
#1046
·
|
|
Re: [DISCUSS] 0.2.3 release and 0.3 branch
Releases are done on Sonatype OSS. For reference, here is original conversation and the original ticket for JanusGraph.
If a committer is interested in stepping up to be a release manager, you can
Releases are done on Sonatype OSS. For reference, here is original conversation and the original ticket for JanusGraph.
If a committer is interested in stepping up to be a release manager, you can
|
By
Jason Plurad <plu...@...>
·
#1045
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
Apologies for bumping up this thread again - just wanted to update on one aspect of codacy behaviour which previously was inconclusive.
I have just had a confirmation that codacy bot actually DOES
Apologies for bumping up this thread again - just wanted to update on one aspect of codacy behaviour which previously was inconclusive.
I have just had a confirmation that codacy bot actually DOES
|
By
Dmitry Kovalev <dk.g...@...>
·
#1044
·
|
|
Re: new contribution - production-worthy in-memory backend with no external dependencies
Just pushed a commit to remove/reclassify all TODOs in the code.
Just pushed a commit to remove/reclassify all TODOs in the code.
|
By
Dmitry Kovalev <dk.g...@...>
·
#1043
·
|
|
JanusGraph Online Meetup Slides & Recording
Hello,
Thanks to all who attended the recent online meetup. We had a lot of folks show up and a ton of great questions. Also, big shout and thank you to Chris, Ryan, Jan, and John for speaking. They
Hello,
Thanks to all who attended the recent online meetup. We had a lot of folks show up and a ton of great questions. Also, big shout and thank you to Chris, Ryan, Jan, and John for speaking. They
|
By
Ted Wilmes <twi...@...>
·
#1042
·
|
|
Grant all JanusGraph PMC members with necessary rights
There are multiple problems which I see which are not yet resolved:
1. We don't own the domain `janusgraph.org` that is why we can't recover accounts for Docker Hub and maven nexus (sonatype I
There are multiple problems which I see which are not yet resolved:
1. We don't own the domain `janusgraph.org` that is why we can't recover accounts for Docker Hub and maven nexus (sonatype I
|
By
Oleksandr Porunov <alexand...@...>
·
#1041
·
|
|
Re: CLA signing automation
Misha, Jason,
Could you please check if "fufler" signed a CLA? If so, could you create a PR to include him into janusgraph-legal repository?
Regards,
Oleksandr
Misha, Jason,
Could you please check if "fufler" signed a CLA? If so, could you create a PR to include him into janusgraph-legal repository?
Regards,
Oleksandr
|
By
Oleksandr Porunov <alexand...@...>
·
#1040
·
|
|
I thought there should be caching setting at hbase backend
When i try to reindex a mixed index with hbase backend, It really bothered me with such exception :
[07:18:22:139] [ERROR] -
When i try to reindex a mixed index with hbase backend, It really bothered me with such exception :
[07:18:22:139] [ERROR] -
|
By
li...@...
·
#1039
·
|
|
Re: new contribution - production-worthy in-memory backend with no external dependencies
Hi Henry,
Thanks for coming back on this.
I had a quick look at the todos right now, and I think they basically can all be removed - which I will do early next week when I come back from travelling.
Hi Henry,
Thanks for coming back on this.
I had a quick look at the todos right now, and I think they basically can all be removed - which I will do early next week when I come back from travelling.
|
By
Dmitry Kovalev <dk.g...@...>
·
#1038
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
I'm going to go with blocking notifications from codacy and I'll open a good first issue to add the link for blocking to CONTRIBUTING.md. The in-line comments are helpful for review and I think
I'm going to go with blocking notifications from codacy and I'll open a good first issue to add the link for blocking to CONTRIBUTING.md. The in-line comments are helpful for review and I think
|
By
Chris Hupman <chris...@...>
·
#1035
·
|
|
Re: new contribution - production-worthy in-memory backend with no external dependencies
Thanks, Dmitry. Please allow us some time for the review. Quick question, there are bunch of TODO in the PR, do you plan to address it soon or is it currently trade-off between time and initial
Thanks, Dmitry. Please allow us some time for the review. Quick question, there are bunch of TODO in the PR, do you plan to address it soon or is it currently trade-off between time and initial
|
By
Henry Saputra <henry....@...>
·
#1034
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
I find inline comments from Codacy convenient. Of course it would be much better if those comments would be grouped in a single review rather then separate comments but frankly, most PRs are much
I find inline comments from Codacy convenient. Of course it would be much better if those comments would be grouped in a single review rather then separate comments but frankly, most PRs are much
|
By
Oleksandr Porunov <alexand...@...>
·
#1033
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
I got a response from them that they forwarded that request to their product team.
Not sure if everyone here is aware of this, but you can also adjust your personal notification settings on GitHub to
I got a response from them that they forwarded that request to their product team.
Not sure if everyone here is aware of this, but you can also adjust your personal notification settings on GitHub to
|
By
Florian Hockmann <f...@...>
·
#1032
·
|
|
Re: new contribution - production-worthy in-memory backend with no external dependencies
Just a gentle reminder - please could anyone spare some time to review?
Thank you,
Dmitry
Just a gentle reminder - please could anyone spare some time to review?
Thank you,
Dmitry
|
By
Dmitry Kovalev <dk.g...@...>
·
#1037
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
I will bet a few pints that when it comes to actually reviewing that big PR by a human, both reviewer and author will also find that having 100 comments from a bot on the PR is as annoying as having
I will bet a few pints that when it comes to actually reviewing that big PR by a human, both reviewer and author will also find that having 100 comments from a bot on the PR is as annoying as having
|
By
Dmitry Kovalev <dk.g...@...>
·
#1036
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
After getting over 100 emails in the past 2 days on the janusgraph-python PR, I must admit I am much more sympathetic to Dmitry's complaint about email spam from in-line comments. The email spam is
After getting over 100 emails in the past 2 days on the janusgraph-python PR, I must admit I am much more sympathetic to Dmitry's complaint about email spam from in-line comments. The email spam is
|
By
Chris Hupman <chris...@...>
·
#1031
·
|
|
Re: JanusGraph online meetup
Here is the link: https://zoom.us/j/231802964
Here is the link: https://zoom.us/j/231802964
|
By
Oleksandr Porunov <alexand...@...>
·
#1029
·
|
|
Re: JanusGraph online meetup
Is there a way to access the meetup link, without providing addevent access to my calendar?
Is there a way to access the meetup link, without providing addevent access to my calendar?
|
By
aman mangal <mangal...@...>
·
#1030
·
|
|
Re: CLA signing automation
Misha, Jason,
Could you please check if VladimirBogomolov signed a CLA? Looks like he signed it 19 days ago but the CLA PR wasn't been submitted to janusgraph-legal repository
Misha, Jason,
Could you please check if VladimirBogomolov signed a CLA? Looks like he signed it 19 days ago but the CLA PR wasn't been submitted to janusgraph-legal repository
|
By
Oleksandr Porunov <alexand...@...>
·
#1028
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
That sounds like a good idea for an improvement. I didn't find any option to configure how Codacy adds these inline comments, so I submitted that as a feature request to them. (I have no idea though
That sounds like a good idea for an improvement. I didn't find any option to configure how Codacy adds these inline comments, so I submitted that as a feature request to them. (I have no idea though
|
By
Florian Hockmann <f...@...>
·
#1027
·
|