|
Re: [PROPOSAL] new repository for .NET driver
Apologies for the delay, but I've created
* https://github.com/JanusGraph/janusgraph-dotnet
* https://github.com/JanusGraph/janusgraph-python
Committers and maintainers should have access to it.
Apologies for the delay, but I've created
* https://github.com/JanusGraph/janusgraph-dotnet
* https://github.com/JanusGraph/janusgraph-python
Committers and maintainers should have access to it.
|
By
Jason Plurad <plu...@...>
·
#725
·
|
|
Re: Serialization error in JanusGraph libraries for Python (Geo Predicate)
Not sure which SO post you mean, but you can simply verify that it's working when you try this:
and check that id is a valid RelationIdentifier.
Great, I implemented a JanusGraphClientBuilder for the
Not sure which SO post you mean, but you can simply verify that it's working when you try this:
and check that id is a valid RelationIdentifier.
Great, I implemented a JanusGraphClientBuilder for the
|
By
Florian Hockmann <f...@...>
·
#724
·
|
|
Re: New committers: Florian Hockmann and Chris Hupman
Congratulations Florian and Chris! Thanks for all your excellent work on the project.
Congratulations Florian and Chris! Thanks for all your excellent work on the project.
|
By
sjudeng <sju...@...>
·
#723
·
|
|
Re: Serialization error in JanusGraph libraries for Python (Geo Predicate)
Thanks a lot Florian for pointing out the JSON structure difference in case of Circle. I just wrapped around the JSON inside a geometry key, and did the normal workflow I was doing before, and I'm
Thanks a lot Florian for pointing out the JSON structure difference in case of Circle. I just wrapped around the JSON inside a geometry key, and did the normal workflow I was doing before, and I'm
|
By
Debasish Kanhar <d.k...@...>
·
#722
·
|
|
Re: Serialization error in JanusGraph libraries for Python (Geo Predicate)
The serialization of Geoshape.Point needs to look exactly like what you got back from the server:
{'@type': 'janusgraph:Geoshape', '@value': {'coordinates': [23.700001, 38.099998]}}
My advise for
The serialization of Geoshape.Point needs to look exactly like what you got back from the server:
{'@type': 'janusgraph:Geoshape', '@value': {'coordinates': [23.700001, 38.099998]}}
My advise for
|
By
Florian Hockmann <f...@...>
·
#721
·
|
|
Re: Serialization error in JanusGraph libraries for Python (Geo Predicate)
Okay, adding a few things here. I was doing quick debug and added following logs to my PointSerializer & CircleSerializer class' dictify method which is used during Serialization.
serializedJSON =
Okay, adding a few things here. I was doing quick debug and added following logs to my PointSerializer & CircleSerializer class' dictify method which is used during Serialization.
serializedJSON =
|
By
Debasish Kanhar <d.k...@...>
·
#720
·
|
|
Re: Serialization error in JanusGraph libraries for Python (Geo Predicate)
Hi Florian.
Thanks for all those tips. I made huge proceedings today in concern with Geoshapes. Thanks for pointing out that Geoshape and Geopredicate are 2 separate things. Somehow it was oversight
Hi Florian.
Thanks for all those tips. I made huge proceedings today in concern with Geoshapes. Thanks for pointing out that Geoshape and Geopredicate are 2 separate things. Somehow it was oversight
|
By
Debasish Kanhar <d.k...@...>
·
#719
·
|
|
New committers: Florian Hockmann and Chris Hupman
On behalf of the JanusGraph Technical Steering Committee (TSC), I'm pleased to welcome 2 new committers on the project!
Florian Hockmann has been a solid contributor. In the JanusGraph 0.3.0 release,
On behalf of the JanusGraph Technical Steering Committee (TSC), I'm pleased to welcome 2 new committers on the project!
Florian Hockmann has been a solid contributor. In the JanusGraph 0.3.0 release,
|
By
Jason Plurad <plu...@...>
·
#718
·
|
|
Re: Serialization error in JanusGraph libraries for Python (Geo Predicate)
There is a difference between Geoshapes and Geo predicates. You are right that Geo predicates are similar to Text predicates and don't need their own serializer as the normal serializer for P (that's
There is a difference between Geoshapes and Geo predicates. You are right that Geo predicates are similar to Text predicates and don't need their own serializer as the normal serializer for P (that's
|
By
Florian Hockmann <f...@...>
·
#717
·
|
|
Re: Serialization error in JanusGraph libraries for Python (Geo Predicate)
Hi Florian,
Thanks for response. Well my understanding was that the implementation was going to be similar for all Geoshapes. I guess my understanding was wrong here. Thanks for pointing that out.
If
Hi Florian,
Thanks for response. Well my understanding was that the implementation was going to be similar for all Geoshapes. I guess my understanding was wrong here. Thanks for pointing that out.
If
|
By
Debasish Kanhar <d.k...@...>
·
#716
·
|
|
Re: Serialization error in JanusGraph libraries for Python (Geo Predicate)
First of all, great to hear that someone is working on a Python driver for JanusGraph!
At a first glance I'd say that the serialization of Geoshape.circle() looks wrong. You serialize them as if they
First of all, great to hear that someone is working on a Python driver for JanusGraph!
At a first glance I'd say that the serialization of Geoshape.circle() looks wrong. You serialize them as if they
|
By
Florian Hockmann <f...@...>
·
#715
·
|
|
Re: [DISCUSS] Pull Request review and approval policy
+1 on Jason's idea.
This helps people who are bit busy with other assignments to have easy way to track the existing PRs needed for approval, and in turn reduces chances of PR reviews getting missed
+1 on Jason's idea.
This helps people who are bit busy with other assignments to have easy way to track the existing PRs needed for approval, and in turn reduces chances of PR reviews getting missed
|
By
Debasish Kanhar <d.k...@...>
·
#714
·
|
|
Serialization error in JanusGraph libraries for Python (Geo Predicate)
Hi all,
I'm currently building JanusGraph libraries for Python so that we can extend functionalities of JanusGraph indexed lookup and Schema management using non JVM based languages.
I was planning a
Hi all,
I'm currently building JanusGraph libraries for Python so that we can extend functionalities of JanusGraph indexed lookup and Schema management using non JVM based languages.
I was planning a
|
By
Debasish Kanhar <d.k...@...>
·
#713
·
|
|
Re: [DISCUSS] Pull Request review and approval policy
Perhaps a weekly update on the PR queue posted on the dev mailing list would be a good idea.
Something like:
# 0.2.2 queue
PR a - needs one more approval
PR b - waiting on revisions
PR c - unreviewed
Perhaps a weekly update on the PR queue posted on the dev mailing list would be a good idea.
Something like:
# 0.2.2 queue
PR a - needs one more approval
PR b - waiting on revisions
PR c - unreviewed
|
By
Jason Plurad <plu...@...>
·
#712
·
|
|
Re: [DISCUSS] Pull Request review and approval policy
Finding the right balance between more review/more approvals and being more efficient is what we aim for. I have been in situations in my PRs where another pair of eyes caught some error I made. I
Finding the right balance between more review/more approvals and being more efficient is what we aim for. I have been in situations in my PRs where another pair of eyes caught some error I made. I
|
By
Jerry He <jerr...@...>
·
#711
·
|
|
Re: [DISCUSS] JanusGraph 0.2.2 release
I agree that maintaining 3 development branches will be tough for us. Ideally we should avoid it at this stage of the project. I am for a last release of 0.2.2 as Jason plans it. (The three PRs don't
I agree that maintaining 3 development branches will be tough for us. Ideally we should avoid it at this stage of the project. I am for a last release of 0.2.2 as Jason plans it. (The three PRs don't
|
By
Jerry He <jerr...@...>
·
#710
·
|
|
Re: [DISCUSS] Pull Request review and approval policy
I am not a committer but here are my thoughts:
1. I think it is enough to maintain 2 active branches right now. Latest release + future release (master). There is plainly no enough committers to
I am not a committer but here are my thoughts:
1. I think it is enough to maintain 2 active branches right now. Latest release + future release (master). There is plainly no enough committers to
|
By
Alexandr Porunov <alexand...@...>
·
#709
·
|
|
[DISCUSS] Pull Request review and approval policy
I have a couple discussion topics to bring up based on our recent history of getting releases out.
1. Based on what we have written in the docs (Chapter 44. Pull Requests), we have a
I have a couple discussion topics to bring up based on our recent history of getting releases out.
1. Based on what we have written in the docs (Chapter 44. Pull Requests), we have a
|
By
Jason Plurad <plu...@...>
·
#708
·
|
|
[DISCUSS] JanusGraph 0.2.2 release
I created a milestone for the 0.2.2 shortly before 0.2.1 was released.
The 0.2 branch is open and the versions are updated to 0.2.2-SNAPSHOT.
These are the open PRs that require review/approvals.
A
I created a milestone for the 0.2.2 shortly before 0.2.1 was released.
The 0.2 branch is open and the versions are updated to 0.2.2-SNAPSHOT.
These are the open PRs that require review/approvals.
A
|
By
Jason Plurad <plu...@...>
·
#707
·
|
|
Re: [VOTE] JanusGraph 0.3.0 release
+1 good job on the hard work for release!
+1 good job on the hard work for release!
|
By
Alexander Patrikalakis <amcpatr...@...>
·
#706
·
|