|
[REPORT] Open Pull Requests 2018-09-04
Open Pull Requests 2018-09-04This report contains a summary of the open pull requests in the JanusGraph project ecosystem. Everybody interested is encouraged to submit review comments and approvals,
Open Pull Requests 2018-09-04This report contains a summary of the open pull requests in the JanusGraph project ecosystem. Everybody interested is encouraged to submit review comments and approvals,
|
By
Jason Plurad <plu...@...>
·
#785
·
|
|
Re: TinkerPop 3.2 vs TinkerPop 3.3 Serialization difference for Predicate class
Apologies for the slow response. Back from a long holiday weekend in the USA.
My opinion is that we need to keep pushing forward on releases and actively encourage users to move up to the latest
Apologies for the slow response. Back from a long holiday weekend in the USA.
My opinion is that we need to keep pushing forward on releases and actively encourage users to move up to the latest
|
By
Jason Plurad <plu...@...>
·
#784
·
|
|
Re: TinkerPop 3.2 vs TinkerPop 3.3 Serialization difference for Predicate class
I'm not against merging this into 0.2, but I'm actually not sure whether we want to do that. My understanding is that new features go mainly into master and that the 0.2 branch mostly gets bug fixes
I'm not against merging this into 0.2, but I'm actually not sure whether we want to do that. My understanding is that new features go mainly into master and that the 0.2 branch mostly gets bug fixes
|
By
Florian Hockmann <f...@...>
·
#783
·
|
|
Re: [PROPOSAL] new repository for .NET driver
@Jason:
I created a initial PR#2 to merge my codebase into official JanusGraph-Python repo you created. While the PR was successful, I wasn't able to add any reviewers, you or Florian or Misha. I'll
@Jason:
I created a initial PR#2 to merge my codebase into official JanusGraph-Python repo you created. While the PR was successful, I wasn't able to add any reviewers, you or Florian or Misha. I'll
|
By
Debasish Kanhar <d.k...@...>
·
#782
·
|
|
Re: TinkerPop 3.2 vs TinkerPop 3.3 Serialization difference for Predicate class
Hi Florian,
Thanks for the link to PR. Didn't know I had stumbled upon the same issue already. Oops :-P
Anyways, quick questions, are there any plan to merge those changes to 0.2 branch? Reason I'm
Hi Florian,
Thanks for the link to PR. Didn't know I had stumbled upon the same issue already. Oops :-P
Anyways, quick questions, are there any plan to merge those changes to 0.2 branch? Reason I'm
|
By
Debasish Kanhar <d.k...@...>
·
#781
·
|
|
Re: [DISCUSS] Official JanusGraph docker image repo
Ok, I moved Mr. Pounds code over into my fork of the new repo and put a "scratch" PR in: https://github.com/JanusGraph/janusgraph-docker/pull/1
Let's move our discussion/feedback on approach over to
Ok, I moved Mr. Pounds code over into my fork of the new repo and put a "scratch" PR in: https://github.com/JanusGraph/janusgraph-docker/pull/1
Let's move our discussion/feedback on approach over to
|
By
Ted Wilmes <twi...@...>
·
#780
·
|
|
[DISCUSS] Adding static code analysis into our review process
JanusGraph currently uses Coverity as a static code analysis tool. While this already led to some findings, it can unfortunately not be used to analyse code changes from pull requests. I wondered
JanusGraph currently uses Coverity as a static code analysis tool. While this already led to some findings, it can unfortunately not be used to analyse code changes from pull requests. I wondered
|
By
Florian Hockmann <f...@...>
·
#779
·
|
|
Re: Using custom properties in ElasticSearchIndex
The PR for this issue is here: https://github.com/JanusGraph/janusgraph/pull/1231
I would appropriate if someone could review it.
Best regards,
Alexandr
The PR for this issue is here: https://github.com/JanusGraph/janusgraph/pull/1231
I would appropriate if someone could review it.
Best regards,
Alexandr
|
By
Alexandr Porunov <alexand...@...>
·
#778
·
|
|
Re: [DISCUSS] Official JanusGraph docker image repo
I think that makes sense as a starting point. I'm assuming there will be a fair amount of testing, discussions, and iterations before it gets pushed up as an official image.
I think that makes sense as a starting point. I'm assuming there will be a fair amount of testing, discussions, and iterations before it gets pushed up as an official image.
|
By
Chris Hupman <chris...@...>
·
#776
·
|
|
Re: [DISCUSS] Official JanusGraph docker image repo
I think I can get to that later this week. I could push Chris' work into a new branch on the new repo and then put a PR in so we could come to some consensus on if that's a good starting point?
I think I can get to that later this week. I could push Chris' work into a new branch on the new repo and then put a PR in so we could come to some consensus on if that's a good starting point?
|
By
Ted Wilmes <twi...@...>
·
#777
·
|
|
Re: [DISCUSS] Official JanusGraph docker image repo
One last question, mainly for Expero folks. Is anyone already intending to make the initial commit? I have a conference this week, but can work on this next week if not.
One last question, mainly for Expero folks. Is anyone already intending to make the initial commit? I have a conference this week, but can work on this next week if not.
|
By
Chris Hupman <chris...@...>
·
#775
·
|
|
Re: [DISCUSS] Pull Request review and approval policy
+1.
I like CTR for upstream merges to help streamline the process.
I personally really like getting a second set of eyes on my commits and enjoy the feedback. That being said I've gotten some great
+1.
I like CTR for upstream merges to help streamline the process.
I personally really like getting a second set of eyes on my commits and enjoy the feedback. That being said I've gotten some great
|
By
Chris Hupman <chris...@...>
·
#774
·
|
|
Re: [PROPOSAL] new repository for a JanusGraph plugin for Apache Ambari
https://github.com/JanusGraph/janusgraph-ambari is created
https://github.com/JanusGraph/janusgraph-ambari is created
|
By
Jason Plurad <plu...@...>
·
#773
·
|
|
Re: [DISCUSS] Official JanusGraph docker image repo
https://github.com/JanusGraph/janusgraph-docker is created
https://github.com/JanusGraph/janusgraph-docker is created
|
By
Jason Plurad <plu...@...>
·
#772
·
|
|
Re: [DISCUSS] Pull Request review and approval policy
There hasn't been any negative responses on this thread. I will submit a PR today to update the PR docs to outline these updates in policy.
1. CTR is already part of our policy
a. Committers are
There hasn't been any negative responses on this thread. I will submit a PR today to update the PR docs to outline these updates in policy.
1. CTR is already part of our policy
a. Committers are
|
By
Jason Plurad <plu...@...>
·
#771
·
|
|
Re: TinkerPop 3.2 vs TinkerPop 3.3 Serialization difference for Predicate class
JanusGraph simply lacks the required GraphSON serializers and deserializers for predicates. I created #1060 to track this issue and fixed it with PR #1061 which was merged into master and not into the
JanusGraph simply lacks the required GraphSON serializers and deserializers for predicates. I created #1060 to track this issue and fixed it with PR #1061 which was merged into master and not into the
|
By
Florian Hockmann <f...@...>
·
#770
·
|
|
Re: Janusgraph + Spark standalone without hadoop
Yeah, a stack trace from Gremlin will us help to see what is going on. That should not be a dependency in that case.
Thanks,
Jerry
Yeah, a stack trace from Gremlin will us help to see what is going on. That should not be a dependency in that case.
Thanks,
Jerry
|
By
Jerry He <jerr...@...>
·
#769
·
|
|
Re: TinkerPop 3.2 vs TinkerPop 3.3 Serialization difference for Predicate class
And, the following are serializers registered in my gremlin-server.yaml for JanusGraph 0.2.1 (I use the default packeged set of serializers):
serializers:
- { className:
And, the following are serializers registered in my gremlin-server.yaml for JanusGraph 0.2.1 (I use the default packeged set of serializers):
serializers:
- { className:
|
By
Debasish Kanhar <d.k...@...>
·
#768
·
|
|
TinkerPop 3.2 vs TinkerPop 3.3 Serialization difference for Predicate class
Hi All,
So as you all know I've been developing Client drivers for JanusGraph. I was able to test my initial version of library against JanusGraph 0.3.0 which uses TP 3.3.3. I now want to test the
Hi All,
So as you all know I've been developing Client drivers for JanusGraph. I was able to test my initial version of library against JanusGraph 0.3.0 which uses TP 3.3.3. I now want to test the
|
By
Debasish Kanhar <d.k...@...>
·
#767
·
|
|
Re: Janusgraph + Spark standalone without hadoop
Ah. I think we might be wrong in our understanding there. As I was trying to read the graph data from my underlaying backend (Cassandra) and not any Graph stored on HDFS using JanusGraph's
Ah. I think we might be wrong in our understanding there. As I was trying to read the graph data from my underlaying backend (Cassandra) and not any Graph stored on HDFS using JanusGraph's
|
By
Debasish Kanhar <d.k...@...>
·
#766
·
|