|
Re: new contribution - production-worthy in-memory backend with no external dependencies
Thanks, Dmitry. Please allow us some time for the review. Quick question, there are bunch of TODO in the PR, do you plan to address it soon or is it currently trade-off between time and initial
Thanks, Dmitry. Please allow us some time for the review. Quick question, there are bunch of TODO in the PR, do you plan to address it soon or is it currently trade-off between time and initial
|
By
Henry Saputra <henry....@...>
·
#1034
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
I find inline comments from Codacy convenient. Of course it would be much better if those comments would be grouped in a single review rather then separate comments but frankly, most PRs are much
I find inline comments from Codacy convenient. Of course it would be much better if those comments would be grouped in a single review rather then separate comments but frankly, most PRs are much
|
By
Oleksandr Porunov <alexand...@...>
·
#1033
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
I got a response from them that they forwarded that request to their product team.
Not sure if everyone here is aware of this, but you can also adjust your personal notification settings on GitHub to
I got a response from them that they forwarded that request to their product team.
Not sure if everyone here is aware of this, but you can also adjust your personal notification settings on GitHub to
|
By
Florian Hockmann <f...@...>
·
#1032
·
|
|
Re: new contribution - production-worthy in-memory backend with no external dependencies
Just a gentle reminder - please could anyone spare some time to review?
Thank you,
Dmitry
Just a gentle reminder - please could anyone spare some time to review?
Thank you,
Dmitry
|
By
Dmitry Kovalev <dk.g...@...>
·
#1037
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
I will bet a few pints that when it comes to actually reviewing that big PR by a human, both reviewer and author will also find that having 100 comments from a bot on the PR is as annoying as having
I will bet a few pints that when it comes to actually reviewing that big PR by a human, both reviewer and author will also find that having 100 comments from a bot on the PR is as annoying as having
|
By
Dmitry Kovalev <dk.g...@...>
·
#1036
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
After getting over 100 emails in the past 2 days on the janusgraph-python PR, I must admit I am much more sympathetic to Dmitry's complaint about email spam from in-line comments. The email spam is
After getting over 100 emails in the past 2 days on the janusgraph-python PR, I must admit I am much more sympathetic to Dmitry's complaint about email spam from in-line comments. The email spam is
|
By
Chris Hupman <chris...@...>
·
#1031
·
|
|
Re: JanusGraph online meetup
Here is the link: https://zoom.us/j/231802964
Here is the link: https://zoom.us/j/231802964
|
By
Oleksandr Porunov <alexand...@...>
·
#1029
·
|
|
Re: JanusGraph online meetup
Is there a way to access the meetup link, without providing addevent access to my calendar?
Is there a way to access the meetup link, without providing addevent access to my calendar?
|
By
aman mangal <mangal...@...>
·
#1030
·
|
|
Re: CLA signing automation
Misha, Jason,
Could you please check if VladimirBogomolov signed a CLA? Looks like he signed it 19 days ago but the CLA PR wasn't been submitted to janusgraph-legal repository
Misha, Jason,
Could you please check if VladimirBogomolov signed a CLA? Looks like he signed it 19 days ago but the CLA PR wasn't been submitted to janusgraph-legal repository
|
By
Oleksandr Porunov <alexand...@...>
·
#1028
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
That sounds like a good idea for an improvement. I didn't find any option to configure how Codacy adds these inline comments, so I submitted that as a feature request to them. (I have no idea though
That sounds like a good idea for an improvement. I didn't find any option to configure how Codacy adds these inline comments, so I submitted that as a feature request to them. (I have no idea though
|
By
Florian Hockmann <f...@...>
·
#1027
·
|
|
Re: CLA signing automation
[ bcc: janusgraph-dev ]
No trouble at all, Chris! You're on the invite.
[ bcc: janusgraph-dev ]
No trouble at all, Chris! You're on the invite.
|
By
Misha Brukman <mbru...@...>
·
#1026
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
I'm definitely on the side of wanting as much automation for PR reviews as we can. As for the number of emails is it possible to configure Codacy to do a single review instead of a review comment per
I'm definitely on the side of wanting as much automation for PR reviews as we can. As for the number of emails is it possible to configure Codacy to do a single review instead of a review comment per
|
By
Chris Hupman <chris...@...>
·
#1025
·
|
|
Re: CLA signing automation
Hey Misha,
If it's not too much trouble I'd be interested in joining the call.
Regards,
Chris
Hey Misha,
If it's not too much trouble I'd be interested in joining the call.
Regards,
Chris
|
By
Chris Hupman <chris...@...>
·
#1024
·
|
|
Re: CLA signing automation
Misha,
I really love to hear that! I am happy that there are progress in the CLA automation direction.
Hope it will be implemented soon.
Misha,
I really love to hear that! I am happy that there are progress in the CLA automation direction.
Hope it will be implemented soon.
|
By
Oleksandr Porunov <alexand...@...>
·
#1023
·
|
|
Re: CLA signing automation
In emailing help...@... to open a ticket (which I believe was the process in the past?), I've learned that (a) Linux Foundation no longer supports that email address, and (b) they are now using Jira
In emailing help...@... to open a ticket (which I believe was the process in the past?), I've learned that (a) Linux Foundation no longer supports that email address, and (b) they are now using Jira
|
By
Misha Brukman <mbru...@...>
·
#1022
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
But for that, the reviewer has to open the Codacy report in a separate windows and then correlate which issue affects which part of the contribution while reviewing that. To be honest, I wouldn't do
But for that, the reviewer has to open the Codacy report in a separate windows and then correlate which issue affects which part of the contribution while reviewing that. To be honest, I wouldn't do
|
By
Florian Hockmann <f...@...>
·
#1021
·
|
|
Re: CLA signing automation
Florian,
It is great news! I really happy to hear that!
Waiting for the bot :)
Florian,
It is great news! I really happy to hear that!
Waiting for the bot :)
|
By
Oleksandr Porunov <alexand...@...>
·
#1020
·
|
|
Re: CLA signing automation
I just asked in the issue I linked above whether it will be possible for us to use the CLA bot of the Linux Foundation and got a very promising response from Dan Kohn:
The gRPC project will beta test
I just asked in the issue I linked above whether it will be possible for us to use the CLA bot of the Linux Foundation and got a very promising response from Dan Kohn:
The gRPC project will beta test
|
By
Florian Hockmann <f...@...>
·
#1019
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
Hi Florian,
On the examples of "stale" codacy-bot issues not being deleted/resolve automatically - please have a look at the PR I mentioned below. The ones which are manually resolved by me are fixed
Hi Florian,
On the examples of "stale" codacy-bot issues not being deleted/resolve automatically - please have a look at the PR I mentioned below. The ones which are manually resolved by me are fixed
|
By
Dmitry Kovalev <dk.g...@...>
·
#1018
·
|
|
Re: [DISCUSS] Adding static code analysis into our review process
Thanks for your feedback on this, Dmitry!
Are you sure about that? Could you provide examples?
I'm only asking because I haven't seen this behaviour yet, but it may of course be possible that I just
Thanks for your feedback on this, Dmitry!
Are you sure about that? Could you provide examples?
I'm only asking because I haven't seen this behaviour yet, but it may of course be possible that I just
|
By
Florian Hockmann <f...@...>
·
#1017
·
|