1. Janusgraph-Dev
  2. Topics

junit being upgraded to 5 next week in master

Chris Hupman <chris...@...>
 

Hi everyone, 

Barring additional reviews I plan to merge the PR to upgrade junit to 5 next Wednesday once it hits lazy consensus. I don't think there's much in the pipeline that would affect it, but i'm planning to not merge any PRs that involve tests since it will result in farodin91 having to rebase and fix other people's tests again, which has already happened two or three times. Junit 5 add some flexibility which should make it easier to add tests around our abundance of inheritance derived complexity.

If anyone else wants to do an review I learned that if you hold alt when you press the button to toggle the diff it'll affect all 241 files, which I found quite useful in the instance.

Cheers,

Chris
Oleksandr Porunov <alexand...@...>
 

Relevant to this topic: https://github.com/JanusGraph/janusgraph/issues/1395
I see that some benchmark tests are removed in that PR. Should we log them somewhere? I think we can provide links in that issue to removed tests or log them here.

On Friday, February 1, 2019 at 9:24:55 PM UTC+2, Chris Hupman wrote:
Hi everyone, 

Barring additional reviews I plan to merge the PR to upgrade junit to 5 next Wednesday once it hits lazy consensus. I don't think there's much in the pipeline that would affect it, but i'm planning to not merge any PRs that involve tests since it will result in farodin91 having to rebase and fix other people's tests again, which has already happened two or three times. Junit 5 add some flexibility which should make it easier to add tests around our abundance of inheritance derived complexity.

If anyone else wants to do an review I learned that if you hold alt when you press the button to toggle the diff it'll affect all 241 files, which I found quite useful in the instance.

Cheers,

Chris
Jan Jansen <faro...@...>
 

All tests that are using JUnitBenchmarkProvider need to be replaced.
https://github.com/JanusGraph/janusgraph/search?q=JUnitBenchmarkProvider&unscoped_q=JUnitBenchmarkProvider

Am Freitag, 1. Februar 2019 20:24:55 UTC+1 schrieb Chris Hupman:

Hi everyone, 

Barring additional reviews I plan to merge the PR to upgrade junit to 5 next Wednesday once it hits lazy consensus. I don't think there's much in the pipeline that would affect it, but i'm planning to not merge any PRs that involve tests since it will result in farodin91 having to rebase and fix other people's tests again, which has already happened two or three times. Junit 5 add some flexibility which should make it easier to add tests around our abundance of inheritance derived complexity.

If anyone else wants to do an review I learned that if you hold alt when you press the button to toggle the diff it'll affect all 241 files, which I found quite useful in the instance.

Cheers,

Chris

1 - 3 of 3