Date 1 - 2 of 2
[NOTE] If they are flaky, please mark them as flaky!
Jan Jansen <faro...@...>
I added a feature to mark flaky tests in the commit https://github.com/JanusGraph/janusgraph/commit/adeaa980d736a0837a33ee33628e1eb7b70b50c1.
How to mark test as flaky? https://github.com/JanusGraph/janusgraph/blob/master/TESTING.md#marking-tests-as-flaky.
Note: I only added test as flaky which fails during the development of this feature.
Florian Hockmann <f...@...>
toggle quoted message Show quoted text
Being able to mark individual tests as flaky is really nice as we don't have to repeat the whole build job any more now! It also makes it easier to spot the flaky tests so we can inspect them to see whether we can make them "less flaky".
The only downside is of course that we'll now get some failed builds where we didn't mark tests as flaky yet. I just restarted some jobs that failed due to a single test and then created issues for these flaky tests (as all jobs were successful with the second run).
We should probably add the flaky marking to these tests shortly so they don't let our build fail for long.
Am Freitag, 1. März 2019 14:04:50 UTC+1 schrieb Jan Jansen:
|1 - 2 of 2|