|
Chris Hupman <chris...@...>
Hey Pylyp,
I'll see if I can do a review on all 4 PRs tomorrow, but it'll require a second approver and all the comments resolved to merge. The size looks reasonable and they all have tests so I think they have a good chance of making it in 0.2.3, but if any of them can't get resolved in time we'll have to retarget at the next release, which will be 0.3.2 in this case.
Chris
On Monday, May 13, 2019 at 2:56:31 PM UTC-7, writetoph1lm wrote: Thanks Chris,
Thanks понедельник, 13 мая 2019 г., 16:52:05 UTC-4 пользователь Chris Hupman написал: Hello,
My current intention is still to push the 0.2.3 release on May 22nd and I'm actively working on the 2 remaining pull requests to meet that deadline. If there's something you would like to get into 0.2.3 you'll want to submit your PR as soon as you can since reviews take time. Also just in case you didn't already know 0.2.3 will be the last 0.2.x release.
Regards,
Chris On Monday, May 13, 2019 at 1:44:50 PM UTC-7, writetoph1lm wrote: Hi All,
We're currently using JG 0.2.2 in production and would like to push out changes to the next 0.2.x release.
CLA is signed and we're good to go. If everybody is ok I can open PR for 0.2 branch and then port changes to master in separate PR.
Thanks вторник, 23 апреля 2019 г., 16:40:08 UTC-4 пользователь Chris Hupman написал: Hi all,
This morning I went through and tagged all the issues and pull requests that I feel belong in the 0.2.3 release. Currently there are only 2 open pull requests targeting the 0.2 branch. I can't think of anything else that needs to be in the final 0.2.x release, but would love some additional input about whether or not anything else should be included. Currently I'm targeting May 22nd for the release date.
I also added issues to the milestone for my stretch goal of generating rpm and deb packages as release artifacts.
Here is a link to the release milestone. Please provide any and all feedback.
Chris
|
|
|
writetoph1lm <writet...@...>
Thanks Chris,
Thanks
понедельник, 13 мая 2019 г., 16:52:05 UTC-4 пользователь Chris Hupman написал:
Hello,
My current intention is still to push the 0.2.3 release on May 22nd and I'm actively working on the 2 remaining pull requests to meet that deadline. If there's something you would like to get into 0.2.3 you'll want to submit your PR as soon as you can since reviews take time. Also just in case you didn't already know 0.2.3 will be the last 0.2.x release.
Regards,
Chris On Monday, May 13, 2019 at 1:44:50 PM UTC-7, writetoph1lm wrote: Hi All,
We're currently using JG 0.2.2 in production and would like to push out changes to the next 0.2.x release.
CLA is signed and we're good to go. If everybody is ok I can open PR for 0.2 branch and then port changes to master in separate PR.
Thanks вторник, 23 апреля 2019 г., 16:40:08 UTC-4 пользователь Chris Hupman написал: Hi all,
This morning I went through and tagged all the issues and pull requests that I feel belong in the 0.2.3 release. Currently there are only 2 open pull requests targeting the 0.2 branch. I can't think of anything else that needs to be in the final 0.2.x release, but would love some additional input about whether or not anything else should be included. Currently I'm targeting May 22nd for the release date.
I also added issues to the milestone for my stretch goal of generating rpm and deb packages as release artifacts.
Here is a link to the release milestone. Please provide any and all feedback.
Chris
|
|
|
Chris Hupman <chris...@...>
Hello,
My current intention is still to push the 0.2.3 release on May 22nd and I'm actively working on the 2 remaining pull requests to meet that deadline. If there's something you would like to get into 0.2.3 you'll want to submit your PR as soon as you can since reviews take time. Also just in case you didn't already know 0.2.3 will be the last 0.2.x release.
Regards,
Chris
On Monday, May 13, 2019 at 1:44:50 PM UTC-7, writetoph1lm wrote: Hi All,
We're currently using JG 0.2.2 in production and would like to push out changes to the next 0.2.x release.
CLA is signed and we're good to go. If everybody is ok I can open PR for 0.2 branch and then port changes to master in separate PR.
Thanks вторник, 23 апреля 2019 г., 16:40:08 UTC-4 пользователь Chris Hupman написал: Hi all,
This morning I went through and tagged all the issues and pull requests that I feel belong in the 0.2.3 release. Currently there are only 2 open pull requests targeting the 0.2 branch. I can't think of anything else that needs to be in the final 0.2.x release, but would love some additional input about whether or not anything else should be included. Currently I'm targeting May 22nd for the release date.
I also added issues to the milestone for my stretch goal of generating rpm and deb packages as release artifacts.
Here is a link to the release milestone. Please provide any and all feedback.
Chris
|
|
|
writetoph1lm <writet...@...>
Hi All,
We're currently using JG 0.2.2 in production and would like to push out changes to the next 0.2.x release.
CLA is signed and we're good to go. If everybody is ok I can open PR for 0.2 branch and then port changes to master in separate PR.
Thanks вторник, 23 апреля 2019 г., 16:40:08 UTC-4 пользователь Chris Hupman написал:
Hi all,
This morning I went through and tagged all the issues and pull requests that I feel belong in the 0.2.3 release. Currently there are only 2 open pull requests targeting the 0.2 branch. I can't think of anything else that needs to be in the final 0.2.x release, but would love some additional input about whether or not anything else should be included. Currently I'm targeting May 22nd for the release date.
I also added issues to the milestone for my stretch goal of generating rpm and deb packages as release artifacts.
Here is a link to the release milestone. Please provide any and all feedback.
Chris
|
|
|
Chris Hupman <chris...@...>
If anyone has cycles I would really like another set of eyes on PR #1479. I pretty much completely rewrote gremlin-server.sh so that it would be fully backwards compatible, but additionally support start, stop, and being run as a service in systemV and SystemD.
I've done testing on centOS 6 and 7 as well as Ubuntu18 to cover testing on SystemD and SystemV. Even if it's just downloading the gremlin-server.sh script and making sure it works in place the way you're used to I would greatly appreciate it.
I started to work on creating a noarch rpm using the changes made in this PR. I'm really looking forward to replacing a ton of the setup in the dockerfile with a single apt install.
On Sunday, May 5, 2019 at 7:09:45 AM UTC-7, Oleksandr Porunov wrote: Thank you Chris for starting this discussion. The milestone and release day looks good to me. I am back from vacation so I will be able to review and test release artifacts when they are ready.
Oleksandr On Tuesday, April 23, 2019 at 11:40:08 PM UTC+3, Chris Hupman wrote: Hi all,
This morning I went through and tagged all the issues and pull requests that I feel belong in the 0.2.3 release. Currently there are only 2 open pull requests targeting the 0.2 branch. I can't think of anything else that needs to be in the final 0.2.x release, but would love some additional input about whether or not anything else should be included. Currently I'm targeting May 22nd for the release date.
I also added issues to the milestone for my stretch goal of generating rpm and deb packages as release artifacts.
Here is a link to the release milestone. Please provide any and all feedback.
Chris
|
|
|
Oleksandr Porunov <alexand...@...>
Thank you Chris for starting this discussion. The milestone and release day looks good to me. I am back from vacation so I will be able to review and test release artifacts when they are ready.
Oleksandr
On Tuesday, April 23, 2019 at 11:40:08 PM UTC+3, Chris Hupman wrote: Hi all,
This morning I went through and tagged all the issues and pull requests that I feel belong in the 0.2.3 release. Currently there are only 2 open pull requests targeting the 0.2 branch. I can't think of anything else that needs to be in the final 0.2.x release, but would love some additional input about whether or not anything else should be included. Currently I'm targeting May 22nd for the release date.
I also added issues to the milestone for my stretch goal of generating rpm and deb packages as release artifacts.
Here is a link to the release milestone. Please provide any and all feedback.
Chris
|
|
|
Chris Hupman <chris...@...>
Hi all,
This morning I went through and tagged all the issues and pull requests that I feel belong in the 0.2.3 release. Currently there are only 2 open pull requests targeting the 0.2 branch. I can't think of anything else that needs to be in the final 0.2.x release, but would love some additional input about whether or not anything else should be included. Currently I'm targeting May 22nd for the release date.
I also added issues to the milestone for my stretch goal of generating rpm and deb packages as release artifacts.
Here is a link to the release milestone. Please provide any and all feedback.
Chris
|
|
|
