[janusgraph-foundationdb] initial fork options


Christopher Jackson <jackson.ch...@...>
 

Thanks Ted and Expero for contributing this code and migrating it to its new home so quickly!


Misha Brukman <mbru...@...>
 

That's great to hear! Thank you to Ted & Expero for contributing your FoundationDB backend to the Janusgraph Project!


On Tue, Jun 30, 2020 at 10:54 AM Ted Wilmes <twi...@...> wrote:
Success! It is transferred over: https://github.com/JanusGraph/janusgraph-foundationdb. I'm excited to see things progress on the FDB front.

Thanks,
Ted

On Fri, Jun 26, 2020 at 2:22 PM Ted Wilmes <twi...@...> wrote:
I have approval on our side. I'll let you all know when it's been transferred over.

Thanks,
Ted

On Wed, Jun 24, 2020 at 12:40 PM Jason Plurad <plu...@...> wrote:
Thanks Ted. Chime back on this thread once you get clearance from your company, then we can move forward after the experoinc repo is transferred over.

On Saturday, June 20, 2020 at 2:42:15 AM UTC-4 Chris Jackson wrote:
My suggestion would also be either option #1 or option #4.

--
You received this message because you are subscribed to a topic in the Google Groups "JanusGraph developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/janusgraph-dev/tleruwXYBzU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to janusgr...@....
To view this discussion on the web visit https://groups.google.com/d/msgid/janusgraph-dev/1bd113bc-877a-4479-93d4-4f8fa7752d4bn%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "JanusGraph developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to janusgr...@....
To view this discussion on the web visit https://groups.google.com/d/msgid/janusgraph-dev/CAGrm2%3DBq-_eo-OveMjkPBTQDF4cS83EJ-uY%3DYn%2BhEaY7tbQ-PA%40mail.gmail.com.


Ted Wilmes <twi...@...>
 

Success! It is transferred over: https://github.com/JanusGraph/janusgraph-foundationdb. I'm excited to see things progress on the FDB front.

Thanks,
Ted

On Fri, Jun 26, 2020 at 2:22 PM Ted Wilmes <twi...@...> wrote:
I have approval on our side. I'll let you all know when it's been transferred over.

Thanks,
Ted

On Wed, Jun 24, 2020 at 12:40 PM Jason Plurad <plu...@...> wrote:
Thanks Ted. Chime back on this thread once you get clearance from your company, then we can move forward after the experoinc repo is transferred over.

On Saturday, June 20, 2020 at 2:42:15 AM UTC-4 Chris Jackson wrote:
My suggestion would also be either option #1 or option #4.

--
You received this message because you are subscribed to a topic in the Google Groups "JanusGraph developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/janusgraph-dev/tleruwXYBzU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to janusgr...@....
To view this discussion on the web visit https://groups.google.com/d/msgid/janusgraph-dev/1bd113bc-877a-4479-93d4-4f8fa7752d4bn%40googlegroups.com.


Ted Wilmes <twi...@...>
 

I have approval on our side. I'll let you all know when it's been transferred over.

Thanks,
Ted

On Wed, Jun 24, 2020 at 12:40 PM Jason Plurad <plu...@...> wrote:
Thanks Ted. Chime back on this thread once you get clearance from your company, then we can move forward after the experoinc repo is transferred over.

On Saturday, June 20, 2020 at 2:42:15 AM UTC-4 Chris Jackson wrote:
My suggestion would also be either option #1 or option #4.

--
You received this message because you are subscribed to a topic in the Google Groups "JanusGraph developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/janusgraph-dev/tleruwXYBzU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to janusgr...@....
To view this discussion on the web visit https://groups.google.com/d/msgid/janusgraph-dev/1bd113bc-877a-4479-93d4-4f8fa7752d4bn%40googlegroups.com.


Jason Plurad <plu...@...>
 

Thanks Ted. Chime back on this thread once you get clearance from your company, then we can move forward after the experoinc repo is transferred over.


On Saturday, June 20, 2020 at 2:42:15 AM UTC-4 Chris Jackson wrote:
My suggestion would also be either option #1 or option #4.


Christopher Jackson <jackson.ch...@...>
 

My suggestion would also be either option #1 or option #4.


Ted Wilmes <twi...@...>
 

Four makes good sense to me. I don't think that'll be an issue on our end but will confirm.

--Ted


f.gri...@...
 

Of course from my point of view, the easiest option is #2, taking my repo (rngcntr/janusgraph-foundationdb) as the base ;)
But to be honest, I don't think this is the cleanest way to go. I developed most of this alone and without review of others. Furthermore, I refactored much of the existing code. I can't speak for the other authors, but I think the situation might be similar for them.

So my suggestion would be to go for #1 or even better #4 as suggested by Misha.


Misha Brukman <mbru...@...>
 

I'd like to propose another option:

4. Ask Ted & Expero if they wouldn't mind transferring the initial repo experoinf/janusgraph-foundationdb into the JanusGraph org as-is so it becomes the authoritative home (rather than forking it), and then each of the existing fork owners can propose PRs to merge their changes incrementally into the new base repo.

On Tue, Jun 16, 2020 at 10:14 AM Jason Plurad <plu...@...> wrote:
For the new janusgraph-foundationdb repo, we need a starting point. Here are a few options:

1. Fork from experoinc/janusgraph-foundationdb into JanusGraph/janusgraph-foundationdb. The external fork authors submit PRs with their changes to the new repo, and the code changes will be reviewed before commit.

2. Fork from one of the external janusgraph-foundationdb forks into JanusGraph/janusgraph-foundationdb. rngcntr/janusgraph-foundationdb has the most commits among the three. The other two forks would submit PRs to the new repo.

3. Have the 3 authors merge their forks first, then fork the unified fork into JanusGraph/janusgraph-foundationdb. This could provide a unified repo before imposing code review process.

I haven't reviewed any of the code out there, so I don't have a strong opinion on any of these options. Open for more ideas or suggestions from the authors, committers, and others in the community.

-- Jason

--
You received this message because you are subscribed to the Google Groups "JanusGraph developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to janusgr...@....
To view this discussion on the web visit https://groups.google.com/d/msgid/janusgraph-dev/ed630d2d-cf9d-44ab-85d4-27042208e932o%40googlegroups.com.


Jason Plurad <plu...@...>
 

For the new janusgraph-foundationdb repo, we need a starting point. Here are a few options:

1. Fork from experoinc/janusgraph-foundationdb into JanusGraph/janusgraph-foundationdb. The external fork authors submit PRs with their changes to the new repo, and the code changes will be reviewed before commit.

2. Fork from one of the external janusgraph-foundationdb forks into JanusGraph/janusgraph-foundationdb. rngcntr/janusgraph-foundationdb has the most commits among the three. The other two forks would submit PRs to the new repo.

3. Have the 3 authors merge their forks first, then fork the unified fork into JanusGraph/janusgraph-foundationdb. This could provide a unified repo before imposing code review process.

I haven't reviewed any of the code out there, so I don't have a strong opinion on any of these options. Open for more ideas or suggestions from the authors, committers, and others in the community.

-- Jason