1. Janusgraph-Dev
  2. Topics

Dead core removal

Yevgeniy Ignatyev <yevgeniy...@...>
 

Hello.

Is there an established convention how no longer useful code should be handled? E.g. there are commented out lines in GraphDatabaseConfiguration.java - like the ones for cluster.partition setting which was made redundant long ago and completely removed from docs in https://github.com/JanusGraph/janusgraph/pull/882 and there are similar commented out parts in that file.

Can I simply submit a PR that removes commented out lines or maybe an umbrella issue to reference in PR and track cleanup across other parts of JanusGraph should be created?

Best regards,
Evgeniy Ignatiev.
Jason Plurad <plu...@...>
 

My opinion is that commented out code can and should be removed. We have the full history in git, and people can find those commented out code blocks in the previous branches 0.1 and 0.2 also. If you'd like to do it all in one PR against master, that would make sense to me.

-- Jason


On Tuesday, May 29, 2018 at 10:46:01 AM UTC-4, Yevgeniy Ignatyev wrote:
Hello.

Is there an established convention how no longer useful code should be handled? E.g. there are commented out lines in GraphDatabaseConfiguration.java - like the ones for cluster.partition setting which was made redundant long ago and completely removed from docs in https://github.com/JanusGraph/janusgraph/pull/882 and there are similar commented out parts in that file.

Can I simply submit a PR that removes commented out lines or maybe an umbrella issue to reference in PR and track cleanup across other parts of JanusGraph should be created?

Best regards,
Evgeniy Ignatiev.

1 - 2 of 2