Hi Jan

can you elaborate on the method ? as far I've seen the new check is checking the name of the repo, and would expect is to start with string `cassandra`

otherwise it would fail and not run.

in our case the project name is `scylladb` hence it doesn't match

can we revert the new version of testcontainers until we can figure a work around this ?

On Tuesday, January 5, 2021 at 6:06:29 PM UTC+2 fa...@... wrote:

Hi

If you like you could open an issue for it. 

We already have a flag to run test against different version of Cassandra you could add Scylla to this test, if you like. 

Greetings,

Jan

On 5. Jan 2021, at 15:58, Israel Fruchter <f...@...> wrote:



close look seem to there a new PR

https://github.com/testcontainers/testcontainers-java/pull/3021

that breaks taking scylla docker as a drop in replacement in the tests...

since it's name doesn't start with "cassandra"... 

running the test suite with the cassandra docker image does work...

Any ideas on how it can be solved ?

On Tuesday, January 5, 2021 at 4:55:27 PM UTC+2 Israel Fruchter wrote:

seem like this one the breaks the code:

commit f52250f092cfe310916a6a9e743a4ba2a4b62607 (HEAD)

Author: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Date:   Mon Dec 28 11:14:35 2020 +0000

    Bump testcontainers.version from 1.14.3 to 1.15.1

    

    Bumps `testcontainers.version` from 1.14.3 to 1.15.1.

    

    Updates `testcontainers` from 1.14.3 to 1.15.1

    - [Release notes](https://github.com/testcontainers/testcontainers-java/releases)

    - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md)

    - [Commits](https://github.com/testcontainers/testcontainers-java/compare/1.14.3...1.15.1)

    

    Updates `elasticsearch` from 1.14.3 to 1.15.1

    - [Release notes](https://github.com/testcontainers/testcontainers-java/releases)

    - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md)

    - [Commits](https://github.com/testcontainers/testcontainers-java/compare/1.14.3...1.15.1)

    

    Updates `cassandra` from 1.14.3 to 1.15.1

    - [Release notes](https://github.com/testcontainers/testcontainers-java/releases)

    - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md)

    - [Commits](https://github.com/testcontainers/testcontainers-java/compare/1.14.3...1.15.1)

    

    Updates `junit-jupiter` from 1.14.3 to 1.15.1

    - [Release notes](https://github.com/testcontainers/testcontainers-java/releases)

    - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md)

    - [Commits](https://github.com/testcontainers/testcontainers-java/compare/1.14.3...1.15.1)

    

    Signed-off-by: dependabot-preview[bot] <s...@...>

On Tuesday, January 5, 2021 at 12:16:14 PM UTC+2 Israel Fruchter wrote:

Recently the docker base tests for scylladb stopped working

the last confirmed one that was working (in our CI) was c97e84ef401d5a17c4c0b37c1af5fdad06db06fd

how can I figure out what is the issue there ?

$ java -version

java version "1.8.0_201"

Java(TM) SE Runtime Environment (build 1.8.0_201-b09)

Java HotSpot(TM) 64-Bit Server VM (build 25.201-b09, mixed mode)

$ mvn clean install -pl janusgraph-cql -Pscylladb

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.085 s <<< FAILURE! - in org.janusgraph.diskstorage.cql.CQLDistributedStoreManagerTest                                              

[ERROR] org.janusgraph.diskstorage.cql.CQLDistributedStoreManagerTest  Time elapsed: 0.085 s  <<< ERROR!                                                                                                     

java.lang.ExceptionInInitializerError                                                                                                                                                                        

        at org.janusgraph.diskstorage.cql.CQLDistributedStoreManagerTest.<clinit>(CQLDistributedStoreManagerTest.java:37)

--
You received this message because you are subscribed to the Google Groups "JanusGraph users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to janusgr...@....
To view this discussion on the web visit https://groups.google.com/d/msgid/janusgraph-users/0141a784-07e2-4e90-af3d-1f4b42995bf3n%40googlegroups.com.