config skip-schema-check=true is not honored for HBase


jigar patel <jigar.9408266552@...>
 

org.apache.hadoop.hbase.security.AccessDeniedException: org.apache.hadoop.hbase.security.AccessDeniedException: Insufficient permissions (user=<user>, scope=<namespace>:<table>, params=[table=<namespace>:<table>],action=CREATE)
at org.apache.hadoop.hbase.security.access.AccessController.requirePermission(AccessController.java:468) at org.apache.hadoop.hbase.security.access.AccessController.preGetTableDescriptors(AccessController.java:2576)

got above error while OLAP without create permission to <user> at line https://github.com/JanusGraph/janusgraph/blob/master/janusgraph-hbase/src/main/java/org/janusgraph/diskstorage/hbase/HBaseStoreManager.java#L732

it succeeded with CREATE permission given to user

looks like it is due to this call https://github.com/JanusGraph/janusgraph/blob/master/janusgraph-hbase/src/main/java/org/janusgraph/diskstorage/hbase/HBaseStoreManager.java#L543 being made regardless of the boolean variable skipSchemaCheck value https://github.com/JanusGraph/janusgraph/blob/master/janusgraph-hbase/src/main/java/org/janusgraph/diskstorage/hbase/HBaseStoreManager.java#L258

is this a bug? 


hadoopmarc@...
 

Hi Jigar,

Can you provide the properties file you used for opening the graph, as well as the complete stacktrace for the exception listed above?

Best wishes,    Marc


jigar patel <jigar.9408266552@...>
 

Hi Marc

Here is the full stack trace,

https://gist.github.com/jigs1993/5cc1682a919cfb5e8290bf4636f1c766

possible fix is here: https://github.com/jigs1993/janusgraph/pull/1/files

Let me know if you think this is actually an issue, i can raise the PR against the master branch


hadoopmarc@...
 

Hi Jigar,

Yes, I think it is an issue. I did not fully dive into it, in particular I did not check whether any tests exist for the "disable schema check" configuration option. So, go ahead and create an issue for it.

Best wishes,   Marc